Check invalid elements in <Blocks> and <Input> strictly #64
+152
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
commented
Oct 1, 2019
| @@ -18,13 +20,16 @@ export interface ParseContext { | |||
| mode: ParseMode | |||
| } | |||
|
|
|||
| export function JSXSlack( | |||
| node: JSXSlack.Node, | |||
| context: ParseContext = { | |||
There was a problem hiding this comment.
An exported JSXSlack no longer have second argument for private use. We updated to use this in internal parseJSX function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding input-compatible props to existed interactive components (#63), the possibility of wrong usage would increase. For example, using
labelprop at interactive components in<Blocks>and<Actions>would not be thrown error but outputs invalid JSON when sending to Slack.For helping user to notice mistake, we've refactored JSX parse logic and added after-parse validation to
<Blocks>and<Input>.Especially these were hard to check rendered elements if is used multi-level
<Fragment>, so we changed internal JSX object to allow defining event function called at after parsed as internal props. Thereby we can validate to the final output of JSON.